fs: use errno constant with ERR_FS_EISDIR - #35563
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit updates rm() to use the EISDIR constant with ERR_FS_EISDIR instead of hard coding -21.
bcoe
approved these changes
Oct 9, 2020
Trott
approved these changes
Oct 9, 2020
richardlau
approved these changes
Oct 9, 2020
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bcoe
approved these changes
Oct 10, 2020
lpinca
approved these changes
Oct 10, 2020
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2020
This commit updates rm() to use the EISDIR constant with ERR_FS_EISDIR instead of hard coding -21. PR-URL: #35563 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
This commit updates rm() to use the EISDIR constant with ERR_FS_EISDIR instead of hard coding -21. PR-URL: #35563 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
This commit updates rm() to use the EISDIR constant with ERR_FS_EISDIR instead of hard coding -21. PR-URL: nodejs#35563 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates rm() to use the EISDIR constant with ERR_FS_EISDIR instead of hard coding -21.
Checklist