FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: run license builder by MylesBorins · Pull Request #35577 · nodejs/node · GitHub

/ node Public

doc: run license builder - #35577

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-gyp-license
ConversationCommits (1)ChecksFiles changed
Closed

doc: run license builder#35577
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-gyp-license

Conversation

MylesBorins commented Oct 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

License is out of date

Created by running ./tools/license-builder.sh

doc: run license builder
8a91edc 
License is out of date
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 9, 2020

nodejs-github-bot commented Oct 9, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/community-committee
  • @nodejs/tsc

mmarchini commented Oct 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Wondering if we can automate that with Actions somehow (either run the tool and autocommit or linter to check for changes). Linter would probably be the easiest and least disruptive approach as the linter could run only when deps/ change.

MylesBorins commented Oct 10, 2020

Copy link
Copy Markdown
Contributor Author

Linter should be reasonably straight forward. Run the command and fail if there is a diff

MylesBorins commented Oct 12, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 708c87d

MylesBorins added a commit that referenced this pull request Oct 12, 2020
doc: run license builder
708c87d 
License is out of date

PR-URL: #35577
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 14, 2020
doc: run license builder
c1bb364 
License is out of date

PR-URL: #35577
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins mentioned this pull request Oct 14, 2020
Merged

bnb commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

@MylesBorins @mmarchini you could also have it automatically PR if there is a diff with @gr2m's create-or-update-pull-request-action: https://github.com/gr2m/create-or-update-pull-request-action

MylesBorins commented Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

I won't haved time to dig into this for a bit if someone else wants to pick it up.

bnb commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

Already working on a PR.

gr2m commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

holler if I can help in any way

bnb mentioned this pull request Oct 19, 2020
Merged
1 task
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
doc: run license builder
f32bcfb 
License is out of date

PR-URL: nodejs#35577
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnb bnb approved these changes
Trott Trott approved these changes
codebytere codebytere approved these changes
gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL