FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-webcrypto-encrypt-decrypt-aes flaky by jasnell · Pull Request #35587 · nodejs/node · GitHub

/ node Public

test: mark test-webcrypto-encrypt-decrypt-aes flaky - #35587

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:flaky-rhe17-aes-webcrypto
ConversationCommits (1)ChecksFiles changed
Closed

test: mark test-webcrypto-encrypt-decrypt-aes flaky#35587
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:flaky-rhe17-aes-webcrypto

Conversation

jasnell commented Oct 10, 2020

Copy link
Copy Markdown
Member

Appears to be flaky only on rhe17-390x. Will be investigating

refs: #35586

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: mark test-webcrypto-encrypt-decrypt-aes flaky
94fcd54 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: nodejs#35586
nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 10, 2020
jasnell added flaky-test Issues and PRs related to the tests with unstable failures on the CI. crypto Issues and PRs related to the crypto subsystem. labels Oct 10, 2020

richardlau commented Oct 10, 2020

Copy link
Copy Markdown
Member

cc @nodejs/platform-s390

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 11, 2020

jasnell commented Oct 11, 2020

Copy link
Copy Markdown
Member Author

Please 👍🏻 to fast-track

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Oct 12, 2020 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33546/ 💚

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 13, 2020
mcollina approved these changes Oct 13, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm + fast track

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2020

github-actions Bot commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

Landed in f7ed5f4...efe60a5

github-actions Bot closed this Oct 13, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 13, 2020
test: mark test-webcrypto-encrypt-decrypt-aes flaky
efe60a5 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: #35586

PR-URL: #35587
Refs: #35586
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
test: mark test-webcrypto-encrypt-decrypt-aes flaky
3d21792 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: #35586

PR-URL: #35587
Refs: #35586
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
test: mark test-webcrypto-encrypt-decrypt-aes flaky
b630e69 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: nodejs#35586

PR-URL: nodejs#35587
Refs: nodejs#35586
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Trott Trott approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL