report: honor setUncaughtExceptionCaptureCallback - #35595
Merged
gireeshpunathil merged 1 commit intoOct 15, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Oct 11, 2020
cjihrig
reviewed
Oct 11, 2020
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Is it possible to add a test for this?
Sorry, something went wrong.
cjihrig
approved these changes
Oct 11, 2020
Comment thread
test/report/test-report-uncaught-exception-override.js
Outdated
Comment thread
test/report/test-report-uncaught-exception-override.js
Outdated
joyeecheung
approved these changes
Oct 12, 2020
richardlau
approved these changes
Oct 12, 2020
jasnell
approved these changes
Oct 13, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This api does not alter the behavior of diagnostic report configured on uncaught exceptions. This is deemed as a bug. Honor this API. Refs: nodejs#35588 PR-URL: nodejs#35595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
gireeshpunathil
force-pushed
the
report-off-on-custom-exception-hook
branch
from
7ea364a to
ddff2b2
Compare
October 15, 2020 07:25
MylesBorins
pushed a commit
that referenced
this pull request
Nov 24, 2020
This api does not alter the behavior of diagnostic report configured on uncaught exceptions. This is deemed as a bug. Honor this API. Refs: #35588 PR-URL: #35595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
This api does not alter the behavior of diagnostic report configured on uncaught exceptions. This is deemed as a bug. Honor this API. Refs: nodejs#35588 PR-URL: nodejs#35595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This api does not alter the behavior of diagnostic
report configured to on uncaught exceptions.
This is deemed as a bug. Honor this API.
Refs: #35588
Checklist
/cc @addaleax