FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix REPLACEME typo by cjihrig · Pull Request #35617 · nodejs/node · GitHub

/ node Public

doc: fix REPLACEME typo - #35617

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:typo
Closed

doc: fix REPLACEME typo#35617
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:typo

Conversation

cjihrig commented Oct 12, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 12, 2020

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FYI I've also included this change on #35575 (which just needs an approval to land).

bcoe commented Oct 12, 2020

Copy link
Copy Markdown
Contributor

@cjihrig @aduh95 should we just go ahead and land #35575, looks quite safe to fast track IMO.

aduh95 commented Oct 12, 2020

Copy link
Copy Markdown
Contributor

@cjihrig @aduh95 should we just go ahead and land #35575, looks quite safe to fast track IMO.

Fine with me! That would unblock nodejs/remark-preset-lint-node#139 which can unsure this doesn't happen again in the future ;)

cjihrig commented Oct 12, 2020

Copy link
Copy Markdown
Contributor Author

Closing in favor of #35575

cjihrig closed this Oct 12, 2020
cjihrig deleted the typo branch October 12, 2020 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL