stream: async iterator stop read if destroyed - #35640
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes some compatibility issues where it is expected that for await stops reading when the stream is destroyed. Refs: nodejs#34887
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Oct 14, 2020
ronag
commented
Oct 14, 2020
Comment thread
test/parallel/test-stream-readable-async-iterators.js
|
|
||
| const iter = Readable.prototype[Symbol.asyncIterator].call(stream); | ||
| await iter.next(); | ||
| await iter.next(); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This test was modified in the original PR, this PR helps bring it back to what it was.
Sorry, something went wrong.
mcollina
approved these changes
Oct 14, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
lpinca
approved these changes
Oct 14, 2020
4 tasks
jasnell
approved these changes
Oct 14, 2020
Copy link
Copy Markdown
Contributor
|
We are looking at landing a backport on 14.x that includes this change. Can we please fast track this so we can keep 14.x and master in sync |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
+1 to fast track |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test-asan continues to fail here GREEEEEEEN |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Oct 15, 2020
Fixes some compatibility issues where it is expected that for await stops reading when the stream is destroyed. Refs: #34887 PR-URL: #35640 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 15, 2020
includes: * stream: simpler and faster Readable async iterator * stream: don't destroy on async iterator success * stream: async iterator stop read if destroyed PR-URL: #34887 Refs: #34035 Refs: #35122 Refs: #35640 Refs: #34680 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some compatibility issues where it is expected
that for await stops reading when the stream is
destroyed.
Refs: #34887
Checklist