[v14.x] Revert "tools: add missing uv_setup_argv() calls" - #35641
Closed
BethGriggs wants to merge 1 commit into
Closed
[v14.x] Revert "tools: add missing uv_setup_argv() calls"#35641BethGriggs wants to merge 1 commit into
BethGriggs wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
4 tasks
Copy link
Copy Markdown
Member
Author
|
Looks like it is this commit as test-asan has passed. @nodejs/release what do you think we should do here? Revert the commit and re-land once we've figured out which other commits need to land alongside it? /cc @richardlau @addaleax |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I think reverting this on v14.x only is fine as long as it passes CI :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
BethGriggs
marked this pull request as ready for review
October 14, 2020 14:51
richardlau
approved these changes
Oct 14, 2020
Merged
XadillaX
reviewed
Oct 15, 2020
XadillaX
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-asan is failing on v14.x. I suspect it is due to this commit - I'm raising this PR to initially just test whether this commit is the cause of the failure (I'm having trouble running test-asan locally).
The original PR passed test-asan, so I suspect if this commit is the cause, it would be due to a related commit missing on v14.x.
This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.
Checklist