FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Updates for remark v13 by nschonni · Pull Request #35647 · nodejs/node · GitHub

/ node Public

doc: Updates for remark v13 - #35647

Merged
Trott merged 0 commit into
nodejs:masterfrom
nschonni:remark-v13
Nov 3, 2020
ConversationCommits (0)ChecksFiles changed
Merged

doc: Updates for remark v13#35647
Trott merged 0 commit into
nodejs:masterfrom
nschonni:remark-v13

Conversation

nschonni commented Oct 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Related to nodejs/remark-preset-lint-node#159

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Oct 14, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 14, 2020
nschonni mentioned this pull request Oct 14, 2020
Merged
nschonni commented Oct 14, 2020
View reviewed changes
Comment thread doc/api/dns.md Outdated

nschonni Oct 14, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This appears to be a small conflict with the v12 and v13. The list-item-bullet-indent can be removed once upgraded to v13

watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2020

nodejs-github-bot commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33632/

nschonni mentioned this pull request Nov 3, 2020
Closed

Trott commented Nov 3, 2020

Copy link
Copy Markdown
Member

Landed in 26fcdb6...1a29c09

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 3, 2020
doc: adjust table alignment for remark v13
dbdd234 
Addresses table-cell-padding rule issues

PR-URL: nodejs#35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott pushed a commit that referenced this pull request Nov 3, 2020
doc: disable no-undefined-references workarounds
07bb0c4 
The manual links appear to be specific workarounds, so just ignore them

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott closed this Nov 3, 2020
Trott merged commit 1a29c09 into nodejs:master Nov 3, 2020
nschonni deleted the remark-v13 branch November 3, 2020 01:05
targos pushed a commit that referenced this pull request Nov 3, 2020
doc: adjust table alignment for remark v13
eb55462 
Addresses table-cell-padding rule issues

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
doc: disable no-undefined-references workarounds
59b36af 
The manual links appear to be specific workarounds, so just ignore them

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
doc: temporarily disable list-item-bullet-indent
c5b9422 
Not an issue with v13 remark, but seems to be a glitch in the disabled
lines in v12 conflicting.

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
doc: adjust table alignment for remark v13
36a24fb 
Addresses table-cell-padding rule issues

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
doc: disable no-undefined-references workarounds
eed82aa 
The manual links appear to be specific workarounds, so just ignore them

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
doc: temporarily disable list-item-bullet-indent
d612c74 
Not an issue with v13 remark, but seems to be a glitch in the disabled
lines in v12 conflicting.

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
doc: adjust table alignment for remark v13
f0f686a 
Addresses table-cell-padding rule issues

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
doc: disable no-undefined-references workarounds
88948d7 
The manual links appear to be specific workarounds, so just ignore them

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
doc: temporarily disable list-item-bullet-indent
eb68a9b 
Not an issue with v13 remark, but seems to be a glitch in the disabled
lines in v12 conflicting.

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
doc: adjust table alignment for remark v13
6e1612f 
Addresses table-cell-padding rule issues

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
doc: disable no-undefined-references workarounds
733c9da 
The manual links appear to be specific workarounds, so just ignore them

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
doc: temporarily disable list-item-bullet-indent
513bed2 
Not an issue with v13 remark, but seems to be a glitch in the disabled
lines in v12 conflicting.

PR-URL: #35647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
watilde watilde approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL