FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: bump remark-lint-preset-node to 1.17.1 by Trott · Pull Request #35668 · nodejs/node · GitHub

/ node Public

tools: bump remark-lint-preset-node to 1.17.1 - #35668

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:lint-md-update
Oct 18, 2020
Merged

tools: bump remark-lint-preset-node to 1.17.1#35668
Trott merged 0 commit into
nodejs:masterfrom
Trott:lint-md-update

Conversation

Trott commented Oct 16, 2020

Copy link
Copy Markdown
Member

First commit:

doc: correct order of metadata for deprecation

This is in preparation for updating remark-preset-lint-node to 1.17.1.

Second commit:

tools: bump remark-lint-preset-node to 1.17.1

Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1.

Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 16, 2020
Trott requested review from aduh95 and bcoe October 16, 2020 04:20

bcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Was the order of deprecation comments one of the things it lints?

This will make the deprecation process much easier 👍

Trott commented Oct 16, 2020

Copy link
Copy Markdown
Member Author

Was the order of deprecation comments one of the things it lints?

Yes. This includes nodejs/remark-preset-lint-node#139 by @aduh95.

Trott commented Oct 18, 2020

Copy link
Copy Markdown
Member Author

Landed in ee85eb9...fbe33aa

Trott added a commit to Trott/io.js that referenced this pull request Oct 18, 2020
This is in preparation for updating remark-preset-lint-node to 1.17.1.

PR-URL: nodejs#35668
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Trott closed this Oct 18, 2020
Trott merged commit fbe33aa into nodejs:master Oct 18, 2020
Trott deleted the lint-md-update branch October 18, 2020 11:58
targos pushed a commit that referenced this pull request May 1, 2021
Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1.

Refs: nodejs/remark-preset-lint-node#139

PR-URL: #35668
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1.

Refs: nodejs/remark-preset-lint-node#139

PR-URL: #35668
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL