FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add windows and c++ coverage by bcoe · Pull Request #35670 · nodejs/node · GitHub

  1. nodejs
  2. node

Repository navigation

test: add windows and c++ coverage #35670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 12 commits into from
Conversation 36 Commits 12 Checks 0 Files changed
Closed

test: add windows and c++ coverage #35670

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
df981ea
test: add windows and C++ coverage
Oct 17, 2020
d91b81d
build: improve coverage configuration
Oct 18, 2020
656160f
chore: attempt to build with gcov
Oct 18, 2020
9eac50b
build: ensure gcovr tool exists
Oct 18, 2020
f869255
chore: tweak codecov.yml file
Oct 18, 2020
f5d6272
multi-line command had issues
Oct 18, 2020
40cb785
chore: delete more output files
Oct 18, 2020
fc7c05c
build: run test-cov rather than test-ci
Oct 18, 2020
5939514
chore: address review
Oct 20, 2020
71f998a
chore: fiddle with gcovr settings
Oct 20, 2020
15d170e
chore: simplify command
Oct 20, 2020
c646f6d
build: a couple more small tweaks to reports
Oct 20, 2020
File filter

Filter by extension

Filter by extension .yml  (1) All 1 file type selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
chore: attempt to build with gcov
  • Loading branch information
bcoe committed Oct 18, 2020
commit 656160fd853d07c743d80599418cdc06fb204ae6
10 changes: 7 additions & 3 deletions .github/workflows/coverage-linux.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ env:
FLAKY_TESTS: dontcare

jobs:
# TODO(bcoe): add support for C++ coverage.
coverage-linux:
runs-on: ubuntu-latest
steps:
Comment thread
bcoe marked this conversation as resolved.
Resolved
Expand All @@ -23,13 +22,18 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --coverage"
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
# The cause is most likely coverage's use of the inspector.
- name: Test
run: NODE_V8_COVERAGE=coverage/tmp make run-ci -j2 V=1 TEST_CI_ARGS="-p dots" || exit 0
- name: Report
- name: Report js
run: npx c8 report --check-coverage
- name: Report gcov
run: cd out && ../gcovr/scripts/gcovr \
--gcov-exclude='.*\b(deps|usr|out|cctest|embedding)\b' -v \
-r Release/obj.target --xml -o ../coverage/coverage.xml \
--gcov-executable=gcov
- name: Output file count
run: ls -l coverage/tmp/ | wc -l
- name: Clean tmp
Expand Down
Back | FazBrowse Home | New Git URL