FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add additional deprecation warning tests for rmdir recursive by iansu · Pull Request #35683 · nodejs/node · GitHub

/ node Public

test: add additional deprecation warning tests for rmdir recursive - #35683

Closed
iansu wants to merge 2 commits into
nodejs:masterfrom
iansu:more-rmdir-recursive-tests
ConversationCommits (2)ChecksFiles changed
Closed

test: add additional deprecation warning tests for rmdir recursive#35683
iansu wants to merge 2 commits into
nodejs:masterfrom
iansu:more-rmdir-recursive-tests

Conversation

iansu commented Oct 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

The recently added code coverage in #35653 highlighted an uncovered case of the rmdir recursive deprecation warning. This PR adds two new tests to ensure we cover all the places where the deprecation warning can be shown in both the sync and async versions.

cc @bcoe @nodejs/tooling

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 16, 2020
iansu changed the title fs: add additional deprecation warning tests for rmdir recursive test: add additional deprecation warning tests for rmdir recursive Oct 16, 2020
iansu force-pushed the more-rmdir-recursive-tests branch from 1c6e32d to 4ea6e4a Compare October 16, 2020 18:11
bcoe reviewed Oct 17, 2020
View reviewed changes

bcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is looking good to me, it would be good to run your new tests with coverage.

I will add a section to the docs on how to do so.

Comment thread test/parallel/test-fs-rmdir-recursive-warns-not-found.js

tmpdir.refresh();


bcoe Oct 17, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: we usually try to avoid unrelated whitespace changes.

iansu Oct 17, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good to know. I'm pretty sure I accidentally added this extra whitespace in my previous PR so I was just cleaning it up.

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Oct 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33696/

Update test/parallel/test-fs-rmdir-recursive-warns-on-file.js
2589f98 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

codecov-io commented Oct 19, 2020

Copy link
Copy Markdown

Codecov Report

Merging #35683 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #35683   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         220      220           
  Lines       73681    73675    -6     
=======================================
- Hits        71031    71028    -3     
+ Misses       2650     2647    -3
Impacted Files Coverage Δ
lib/internal/url.js 93.94% <0.00%> (-0.03%) ⬇️
lib/_http_server.js 98.45% <0.00%> (+0.10%) ⬆️
lib/internal/fs/utils.js 95.97% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f25fe8...2589f98. Read the comment docs.

nodejs-github-bot commented Oct 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33742/

nodejs-github-bot commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33784/

bcoe commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

@tniessen @aduh95 checking whether your review has been addressed?

bcoe added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 23, 2020
aduh95 pushed a commit that referenced this pull request Oct 24, 2020
test: add additional deprecation warning tests for rmdir recursive
c5b9b5b 
PR-URL: #35683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 commented Oct 24, 2020

Copy link
Copy Markdown
Contributor

Landed in c5b9b5b

aduh95 closed this Oct 24, 2020
targos pushed a commit that referenced this pull request Nov 3, 2020
test: add additional deprecation warning tests for rmdir recursive
0c5e8ed 
PR-URL: #35683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen left review comments
Trott Trott approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
bcoe bcoe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL