FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: remove unsupported %.* specifier by mmomtchev · Pull Request #35694 · nodejs/node · GitHub

/ node Public

http2: remove unsupported %.* specifier - #35694

Closed
mmomtchev wants to merge 1 commit into
nodejs:masterfrom
mmomtchev:debug-crash-printf
ConversationCommits (1)ChecksFiles changed
Closed

http2: remove unsupported %.* specifier#35694
mmomtchev wants to merge 1 commit into
nodejs:masterfrom
mmomtchev:debug-crash-printf

Conversation

mmomtchev commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

The debug sprintf doesn't support %.* specifiers

Fixes: #35688

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

http2: remove unsupported %.* specifier
1d354d4 
The debug sprintf doesn't support %.* specifiers

Fixes: nodejs#35688

nodejs-github-bot commented Oct 17, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. labels Oct 17, 2020

codecov-io commented Oct 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #35694 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #35694   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         220      220           
  Lines       73681    73681           
=======================================
+ Hits        71031    71032    +1     
+ Misses       2650     2649    -1
Impacted Files Coverage Δ
lib/_http_server.js 98.45% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce5a03...1d354d4. Read the comment docs.

mscdex commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

Are we sure this is safe?

According to the documentation (emphasis mine):

The msg is typically NULL-terminated string of length len.

addaleax approved these changes Oct 17, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mscdex Currently, this is always true, yes, and I think changing this would have to be considered a breaking change on the nghttp2 side

Trott commented Oct 18, 2020

Copy link
Copy Markdown
Member

Non-blocking naive questions: Can we/should we add a test? A lint rule? An assertion or other check/confirmation of NULL-termination?

addaleax commented Oct 18, 2020

Copy link
Copy Markdown
Member

Can we/should we add a test?

I would not add a test for specific debugging statements.

A lint rule?

That would be great, but it might be quite a bit of effort.

An assertion or other check/confirmation of NULL-termination?

I don’t see any issue with adding DCHECK_LE(strlen(message), len);.

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2020

nodejs-github-bot commented Oct 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33740/

nodejs-github-bot commented Oct 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33756/

devnexen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 21, 2020
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2020

github-actions Bot commented Oct 24, 2020

Copy link
Copy Markdown
Contributor

Landed in c5b9b5b...7083425

github-actions Bot closed this Oct 24, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 24, 2020
http2: remove unsupported %.* specifier
7083425 
The debug sprintf doesn't support %.* specifiers

Fixes: #35688

PR-URL: #35694
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
http2: remove unsupported %.* specifier
cfe61b8 
The debug sprintf doesn't support %.* specifiers

Fixes: #35688

PR-URL: #35694
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
http2: remove unsupported %.* specifier
1901610 
The debug sprintf doesn't support %.* specifiers

Fixes: #35688

PR-URL: #35694
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
http2: remove unsupported %.* specifier
39d6e81 
The debug sprintf doesn't support %.* specifiers

Fixes: #35688

PR-URL: #35694
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
http2: remove unsupported %.* specifier
2dbaaf9 
The debug sprintf doesn't support %.* specifiers

Fixes: #35688

PR-URL: #35694
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
+3 more reviewers
fhinkel fhinkel approved these changes
devnexen devnexen approved these changes
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

%.* is not a supported debug specifier

10 participants

Back | FazBrowse Home | New Git URL