FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

console: use more primordials by aduh95 · Pull Request #35734 · nodejs/node · GitHub

/ node Public

console: use more primordials - #35734

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:console-refactor-primordials
Nov 5, 2020
ConversationCommits (1)ChecksFiles changed
Merged

console: use more primordials#35734
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:console-refactor-primordials

Conversation

aduh95 commented Oct 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport requested because optional chaining is not available on Node.js 12. No need for optional chaining after all 😅

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Oct 21, 2020
aduh95 added backport-requested-v12.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 21, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020

This comment has been minimized.

Sign in to view

aduh95 commented Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

Why am I getting TypeError: StringPrototypeReplaceAll is not a function? 🤔

targos commented Oct 21, 2020

Copy link
Copy Markdown
Member

My guess is that the method is not available to primordials because it can be disabled in V8 with node --no-harmony-string-replaceall.

This comment has been minimized.

Sign in to view

aduh95 commented Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

My guess is that the method is not available to primordials because it can be disabled in V8 with node --no-harmony-string-replaceall.

Interesting. Well I guess we'll have to refrain from using it in node core for the time being then…

This comment has been minimized.

Sign in to view
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed backport-requested-v12.x labels Oct 28, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33910/

aduh95 added the review wanted PRs that need reviews. label Oct 28, 2020
aduh95 requested a review from targos October 28, 2020 15:34

aduh95 commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

@nodejs/console Can you review this please?

Trott approved these changes Oct 31, 2020
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but needs a rebase

aduh95 force-pushed the console-refactor-primordials branch from 446aa98 to f2c9f81 Compare October 31, 2020 18:57
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2020

nodejs-github-bot commented Nov 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34005/

aduh95 mentioned this pull request Nov 1, 2020
Closed
2 tasks
console: use more primordials
1f6ca18 
PR-URL: nodejs#35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95 force-pushed the console-refactor-primordials branch from f2c9f81 to 1f6ca18 Compare November 5, 2020 22:12

aduh95 commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 1f6ca18

aduh95 merged commit 1f6ca18 into nodejs:master Nov 5, 2020
aduh95 deleted the console-refactor-primordials branch November 5, 2020 22:13
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
console: use more primordials
9757b47 
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
console: use more primordials
c5188e9 
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
console: use more primordials
a2867cd 
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
console: use more primordials
568e617 
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
targos Awaiting requested review from targos

Assignees

No one assigned

Labels

console Issues and PRs related to the console subsystem. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL