tools: add msvc /P output to .gitignore - #35735
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/platform-windows @targos |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
How did you add the /P argument? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index fd786d024e..696474c053 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -203,7 +203,7 @@
'target_defaults': {
'msvs_settings': {
'VCCLCompilerTool': {
- 'AdditionalOptions': ['/utf-8']
+ 'AdditionalOptions': ['/utf-8', '/P']
}
},
},Recently use case is #35433. The clang support maybe require us to patch v8 again. |
Sorry, something went wrong.
targos
approved these changes
Oct 27, 2020
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@nodejs/build-files
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35735 ✔ Done loading data for nodejs/node/pull/35735 ----------------------------------- PR info ------------------------------------ Title tools: add msvc /P output to .gitignore (#35735) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch gengjiawen:msvc-ignore -> nodejs:master Labels meta Commits 1 - tools: add msvc /P output to .gitignore Committers 1 - Jiawen Geng PR-URL: https://github.com/nodejs/node/pull/35735 Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35735 Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected ℹ This PR was created on Wed, 21 Oct 2020 10:47:38 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/35735#pullrequestreview-517615271 ✖ This PR needs to wait 9 more hours to land (or 0 hours if there is one more approval) -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/332615436 |
Sorry, something went wrong.
gengjiawen
added a commit
that referenced
this pull request
Oct 30, 2020
PR-URL: #35735 Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35735 Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 3, 2021
PR-URL: #35735 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 6, 2021
PR-URL: #35735 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty useful when debug missing symbol on windows.
See https://docs.microsoft.com/en-us/cpp/build/reference/p-preprocess-to-a-file?view=vs-2019