doc: use kbd element in readline doc prose - #35737
Merged
Trott merged 1 commit intoOct 26, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Before:
After:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #35737 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 223 223
Lines 73685 73685
==========================================
- Hits 71038 71035 -3
- Misses 2647 2650 +3
Continue to review full report at Codecov.
|
Sorry, something went wrong.
silverwind
approved these changes
Oct 21, 2020
fhinkel
approved these changes
Oct 26, 2020
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: nodejs#35737 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: #35737 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: #35737 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: #35737 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: #35737 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.
Checklist