FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc,esm: document experimental warning removal by aduh95 · Pull Request #35750 · nodejs/node · GitHub

/ node Public

doc,esm: document experimental warning removal - #35750

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:esm-warning-removal-history
Oct 22, 2020
Merged

doc,esm: document experimental warning removal#35750
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:esm-warning-removal-history

Conversation

aduh95 commented Oct 22, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

aduh95 added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 22, 2020
aduh95 requested a review from guybedford October 22, 2020 10:21

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

nodejs-github-bot added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 22, 2020

aduh95 commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

fast-track to include it in #35749?

Comment thread doc/api/esm.md Outdated
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 22, 2020
PR-URL: nodejs#35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
aduh95 force-pushed the esm-warning-removal-history branch from f1e53ff to 3f4ec9c Compare October 22, 2020 15:23

aduh95 commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 3f4ec9c

aduh95 merged commit 3f4ec9c into nodejs:master Oct 22, 2020
aduh95 deleted the esm-warning-removal-history branch October 22, 2020 15:24
aduh95 added a commit to aduh95/node that referenced this pull request Oct 23, 2020
PR-URL: nodejs#35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
Backport-PR-URL: #35757
PR-URL: #35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos mentioned this pull request Nov 3, 2020
MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
Backport-PR-URL: #35757
PR-URL: #35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
PR-URL: #35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35750
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL