Update fs.md (minor indentation issue in /doc) - #35771
Merged
Trott merged 1 commit intoOct 25, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Trott
approved these changes
Oct 23, 2020
Copy link
Copy Markdown
Member
|
Welcome @ax1, and thanks for the pull request! |
Sorry, something went wrong.
richardlau
approved these changes
Oct 23, 2020
aduh95
approved these changes
Oct 24, 2020
lpinca
approved these changes
Oct 24, 2020
gireeshpunathil
approved these changes
Oct 25, 2020
Trott
approved these changes
Oct 25, 2020
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: nodejs#35771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Copy link
Copy Markdown
Member
|
Landed in bae7dde Thanks for the contribution! 🎉 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: #35771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: #35771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: #35771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: #35771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indentation in https://nodejs.org/docs/latest/api/fs.html#fs_fs_promises_api is not correct (level 2 and it should be to level 3).