doc: remove stability warning in v8 module doc - #35774
Merged
Trott merged 1 commit intoOct 25, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It may make sense to add a note that the underlying V8 APIs cannot be guaranteed but I'm not even sure that's true. We have tests and if stuff breaks in this module, that would be a blocker presumably. |
Sorry, something went wrong.
targos
approved these changes
Oct 23, 2020
addaleax
approved these changes
Oct 23, 2020
lpinca
approved these changes
Oct 23, 2020
gireeshpunathil
approved these changes
Oct 24, 2020
watilde
approved these changes
Oct 24, 2020
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: nodejs#35774 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: #35774 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: #35774 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: #35774 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: #35774 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove note indicating that the APIs can change at any time. This module
migrated from Experimental to Stable 6 years ago (in io.js 1.4.2).
Checklist