FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update acorn to v8.0.4 by targos · Pull Request #35791 · nodejs/node · GitHub

/ node Public

deps: update acorn to v8.0.4 - #35791

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-acorn
ConversationCommits (1)ChecksFiles changed
Closed

deps: update acorn to v8.0.4#35791
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-acorn

Conversation

targos commented Oct 24, 2020

Copy link
Copy Markdown
Member

This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

deps: update acorn to v8.0.4
7338e39 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

nodejs-github-bot commented Oct 24, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/community-committee
  • @nodejs/tsc

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 24, 2020
targos added request-ci Add this label to start a Jenkins CI on a PR. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 24, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2020

nodejs-github-bot commented Oct 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33846/

Trott reviewed Oct 24, 2020
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM

targos added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 25, 2020
mcollina approved these changes Oct 25, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

jasnell approved these changes Oct 26, 2020
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🥳 🎉 🥳 🎉 🥳 🎉

jasnell commented Oct 26, 2020

Copy link
Copy Markdown
Member

Do you know if it also supports the new logical operators? e.g. ??= and !!= etc

targos commented Oct 26, 2020

Copy link
Copy Markdown
Member Author

@jasnell I think they are supported, but only with ecmaVersion: 2021. I would suggest to enable it in a separate PR so this one can be cherry-picked to v14.

bnb approved these changes Oct 26, 2020
View reviewed changes

bnb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approving from the CommComm perspective since it's requested by the bot. Cursory glance at the markdown content + License changes, plus an RSLGTM on code since a lot of folks I trust to do the work there have approved.

gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2020

github-actions Bot commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

Landed in ed5e539...16b2bc0

github-actions Bot closed this Oct 27, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
deps: update acorn to v8.0.4
16b2bc0 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos deleted the update-acorn branch October 27, 2020 05:35
richardlau mentioned this pull request Oct 27, 2020
Closed
targos added a commit that referenced this pull request Nov 3, 2020
deps: update acorn to v8.0.4
52a77db 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
deps: update acorn to v8.0.4
bfd30cc 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
deps: update acorn to v8.0.4
dc5fdb8 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs added a commit that referenced this pull request Dec 15, 2020
2020-12-15, Version 14.15.2 'Fermium' (LTS)
2b6dd9c 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
deps: update acorn to v8.0.4
7367e6c 
This adds support for nullish coalescing, optional chaining and
numeric separators.
The acorn-numeric-separator plugin can be removed.

PR-URL: #35791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 15, 2020
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a2f9a70 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs added a commit that referenced this pull request Dec 15, 2020
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a150926 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
bnb bnb approved these changes
Trott Trott approved these changes
watilde watilde approved these changes
codebytere codebytere approved these changes
cjihrig cjihrig approved these changes
gengjiawen gengjiawen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL