FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add upstream test cases to urlsearchparams by watilde · Pull Request #35792 · nodejs/node · GitHub

/ node Public

test: add upstream test cases to urlsearchparams - #35792

Merged
Trott merged 1 commit into
nodejs:masterfrom
watilde:wpt-url
Oct 27, 2020
Merged

test: add upstream test cases to urlsearchparams#35792
Trott merged 1 commit into
nodejs:masterfrom
watilde:wpt-url

Conversation

watilde commented Oct 25, 2020

Copy link
Copy Markdown
Member

Refs: web-platform-tests/wpt#26126

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

watilde added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 25, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020

This comment has been minimized.

watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020

This comment has been minimized.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020

This comment has been minimized.

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM

watilde added dont-land-on-v14.x author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 26, 2020

Copy link
Copy Markdown
Collaborator

Refs: web-platform-tests/wpt#26126

PR-URL: nodejs#35792
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Oct 27, 2020

Copy link
Copy Markdown
Member

Landed in f9c9c21

Trott merged commit f9c9c21 into nodejs:master Oct 27, 2020
watilde deleted the wpt-url branch October 27, 2020 14:01
targos pushed a commit that referenced this pull request Nov 3, 2020
Refs: web-platform-tests/wpt#26126

PR-URL: #35792
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL