doc,test: update v8 method doc and comment - #35795
Merged
Trott merged 1 commit intoOct 27, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
force-pushed
the
cachedDataVersionTag
branch
2 times, most recently
from
9859b08 to
ad97155
Compare
October 25, 2020 12:59
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #35795 +/- ##
==========================================
- Coverage 96.40% 87.89% -8.52%
==========================================
Files 223 477 +254
Lines 73685 113172 +39487
Branches 0 25426 +25426
==========================================
+ Hits 71038 99473 +28435
- Misses 2647 7996 +5349
- Partials 0 5703 +5703
|
Sorry, something went wrong.
watilde
approved these changes
Oct 25, 2020
lpinca
approved these changes
Oct 25, 2020
Comment thread
test/parallel/test-v8-version-tag.js
Outdated
Trott
force-pushed
the
cachedDataVersionTag
branch
from
ad97155 to
641ef5a
Compare
October 26, 2020 04:29
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gireeshpunathil
approved these changes
Oct 26, 2020
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: nodejs#35795 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Trott
force-pushed
the
cachedDataVersionTag
branch
from
641ef5a to
245ec6f
Compare
October 27, 2020 13:19
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation and test comment for v8.cachedDataVersionTag().
Checklist