test: add onerror test cases to policy - #35797
Closed
watilde wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
watilde
force-pushed
the
test-policy-onerror
branch
from
878cfeb to
ab64c67
Compare
October 25, 2020 14:15
watilde
force-pushed
the
test-policy-onerror
branch
from
ab64c67 to
262a4c8
Compare
October 25, 2020 14:24
Copy link
Copy Markdown
Contributor
|
@watilde are you able to follow these updated instructions, to check coverage locally? |
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
@watilde I can see your change here, and it successfully increases coverage on the file (see: here). |
Sorry, something went wrong.
4 tasks
Increase test coverage of lib/internal/policy/manifest.js
watilde
force-pushed
the
test-policy-onerror
branch
from
262a4c8 to
e63d487
Compare
October 25, 2020 16:15
Copy link
Copy Markdown
Member
Author
|
@bcoe That doc is v good to know! I ran in my local now and could confirm the coverage was increased as expected with my last pushed commit: |
Sorry, something went wrong.
bcoe
approved these changes
Oct 25, 2020
This comment has been minimized.
jasnell
approved these changes
Oct 26, 2020
jasnell
approved these changes
Oct 26, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Oct 28, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35797 ✔ Done loading data for nodejs/node/pull/35797 ----------------------------------- PR info ------------------------------------ Title test: add onerror test cases to policy (#35797) Author Daijiro Wachi (@watilde) Branch watilde:test-policy-onerror -> nodejs:master Labels author ready, policy, test Commits 1 - test: add onerror test cases to policy Committers 1 - Daijiro Wachi PR-URL: https://github.com/nodejs/node/pull/35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe Reviewed-By: James M Snell Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe Reviewed-By: James M Snell Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-27T14:36:48Z: https://ci.nodejs.org/job/node-test-pull-request/33886/ - Querying data for job/node-test-pull-request/33886/ ✔ Build data downloaded - Querying failures of job/node-test-commit/41685/ ✔ Data downloaded ✖ 3 failure(s) on the last Jenkins CI run ℹ This PR was created on Sun, 25 Oct 2020 14:14:02 GMT ✔ Approvals: 3 ✔ - Ben Coe (@bcoe): https://github.com/nodejs/node/pull/35797#pullrequestreview-516404681 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35797#pullrequestreview-516924772 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35797#pullrequestreview-518679268 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/334784370 |
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
watilde
added a commit
that referenced
this pull request
Oct 29, 2020
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase test coverage of lib/internal/policy/manifest.js
Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60
Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146
Checklist