tools: update ESLint to 7.12.1 - #35799
Merged
cjihrig merged 2 commits intoOct 31, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Trott
approved these changes
Oct 25, 2020
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Rubber-stamp LGTM
Sorry, something went wrong.
juanarbol
approved these changes
Oct 26, 2020
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
watilde
approved these changes
Oct 26, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35799 ✔ Done loading data for nodejs/node/pull/35799 ----------------------------------- PR info ------------------------------------ Title tools: update ESLint to 7.12.1 (#35799) Author Colin Ihrig (@cjihrig) Branch cjihrig:eslint -> nodejs:master Labels tools Commits 2 - tools: update ESLint to 7.12.0 - tools: update ESLint to 7.12.1 Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/35799 Reviewed-By: Rich Trott Reviewed-By: Juan José Arboleda Reviewed-By: Daijiro Wachi ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35799 Reviewed-By: Rich Trott Reviewed-By: Juan José Arboleda Reviewed-By: Daijiro Wachi -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: update ESLint to 7.12.0 ⚠ - tools: update ESLint to 7.12.1 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-31T21:09:33Z: https://ci.nodejs.org/job/node-test-pull-request/34003/ - Querying data for job/node-test-pull-request/34003/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sun, 25 Oct 2020 14:49:54 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35799#pullrequestreview-516395615 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/35799#pullrequestreview-516416391 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35799#pullrequestreview-516417296 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/339529805 |
Sorry, something went wrong.
Update ESLint to 7.12.0 PR-URL: nodejs#35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Update ESLint to 7.12.1 PR-URL: nodejs#35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Update ESLint to 7.12.0 PR-URL: #35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Update ESLint to 7.12.1 PR-URL: #35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 16, 2021
Update ESLint to 7.12.0 PR-URL: #35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 16, 2021
Update ESLint to 7.12.1 PR-URL: #35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Update ESLint to 7.12.0 PR-URL: #35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Update ESLint to 7.12.1 PR-URL: #35799 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 7.12.1
Checklist