events: add a few tests - #35806
Closed
benjamingr wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Port a few tests from what (commit message)? |
Sorry, something went wrong.
benjamingr
force-pushed
the
event-target-tests
branch
from
b7efa9f to
702b621
Compare
October 26, 2020 09:54
Copy link
Copy Markdown
Member
Author
|
I initially wanted to port tests from chromium but couldn't find relevant ones - so I just went over the spec looking for bits we don't cover and added tests for them. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #35806 +/- ##
==========================================
- Coverage 96.87% 87.89% -8.98%
==========================================
Files 212 477 +265
Lines 69486 113171 +43685
Branches 0 25427 +25427
==========================================
+ Hits 67315 99475 +32160
- Misses 2171 7994 +5823
- Partials 0 5702 +5702
|
Sorry, something went wrong.
Trott
approved these changes
Oct 26, 2020
jasnell
reviewed
Oct 26, 2020
Comment thread
test/parallel/test-eventtarget.js
Outdated
jasnell
approved these changes
Oct 26, 2020
3 tasks
benjamingr
force-pushed
the
event-target-tests
branch
from
702b621 to
c363016
Compare
October 26, 2020 16:28
This comment has been minimized.
ExE-Boss
reviewed
Oct 28, 2020
Comment thread
lib/internal/event_target.js
Outdated
benjamingr
force-pushed
the
event-target-tests
branch
from
54624c7 to
3ad306a
Compare
October 28, 2020 18:23
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Member
Author
|
Rebased |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35806 ✔ Done loading data for nodejs/node/pull/35806 ----------------------------------- PR info ------------------------------------ Title events: add a few tests (#35806) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch benjamingr:event-target-tests -> nodejs:master Labels author ready, events, test Commits 1 - events: add a few tests Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/35806 Reviewed-By: Rich Trott Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35806 Reviewed-By: Rich Trott Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - events: add a few tests ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-03T14:36:19Z: https://ci.nodejs.org/job/node-test-pull-request/34039/ - Querying data for job/node-test-pull-request/34039/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 26 Oct 2020 09:13:53 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35806#pullrequestreview-516666200 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35806#pullrequestreview-516905787 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/343910509 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@aduh95 can you LGTM after the rebase so I can land with the commit queue? (assuming you think the changes are LGTM) |
Sorry, something went wrong.
aduh95
approved these changes
Nov 3, 2020
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 4, 2020
PR-URL: #35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few EventTarget tests I've found by playing with the code and "porting" bits of the spec I've read.
Note that at the moment Chrome has different prototype keys for Event though I could not figure out if that bit is actually required by the spec.
Checklist