FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix reference to googletest test fixture by tniessen · Pull Request #35813 · nodejs/node · GitHub

/ node Public

doc: fix reference to googletest test fixture - #35813

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-fix-ref-to-googletest-test-fixture
Closed

doc: fix reference to googletest test fixture#35813
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-fix-ref-to-googletest-test-fixture

Conversation

Copy link
Copy Markdown
Member

URLs are case-sensitive, so the current link results in a 404, and the anchor also does not exist.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 26, 2020
tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020

Copy link
Copy Markdown
Collaborator

gengjiawen pushed a commit that referenced this pull request Oct 30, 2020
PR-URL: #35813
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

Copy link
Copy Markdown
Member

Landed in 5947862

gengjiawen closed this Oct 30, 2020
targos pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35813
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
PR-URL: #35813
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35813
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35813
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL