FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: make the benchmark tool work with Node 10 by joyeecheung · Pull Request #35817 · nodejs/node · GitHub

/ node Public

benchmark: make the benchmark tool work with Node 10 - #35817

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:bench-compat
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: make the benchmark tool work with Node 10#35817
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:bench-compat

Conversation

joyeecheung commented Oct 26, 2020

Copy link
Copy Markdown
Member

Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

benchmark: make the benchmark tool work with Node 10
49f7a48 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Oct 26, 2020
lpinca reviewed Oct 27, 2020
View reviewed changes
Comment thread benchmark/common.js
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020

nodejs-github-bot commented Oct 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33969/

mhdawson approved these changes Oct 30, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33987/

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020

nodejs-github-bot commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34025/

mmarchini approved these changes Nov 3, 2020
View reviewed changes

mmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

any way we can test/lint for valid syntax for Node.js v10?

richardlau commented Nov 3, 2020

Copy link
Copy Markdown
Member

any way we can test/lint for valid syntax for Node.js v10?

Run the lint action with Node.js 10?

joyeecheung added a commit that referenced this pull request Nov 4, 2020
benchmark: make the benchmark tool work with Node 10
dbcadf0 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>

joyeecheung commented Nov 4, 2020

Copy link
Copy Markdown
Member Author

Landed in dbcadf0, thanks!

joyeecheung closed this Nov 4, 2020
targos pushed a commit that referenced this pull request Nov 4, 2020
benchmark: make the benchmark tool work with Node 10
76ebae4 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
targos mentioned this pull request Nov 4, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
benchmark: make the benchmark tool work with Node 10
5db0b07 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
benchmark: make the benchmark tool work with Node 10
c062d0b 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
benchmark: make the benchmark tool work with Node 10
f648796 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
Trott Trott approved these changes
watilde watilde approved these changes
gengjiawen gengjiawen approved these changes
ZYSzys ZYSzys approved these changes
+2 more reviewers
mmarchini mmarchini approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL