zlib: test BrotliCompress throws invalid arg value by RaisinTen · Pull Request #35830 · nodejs/node · GitHub

Improving the coverage for this:

Lines 807 to 809 in 0ca8617

    
             throw new ERR_INVALID_ARG_TYPE('options.params[key]', 
        
                                            'number', opts.params[origKey]); 
        
           }

First time I'm writing a test! 😃

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/33888/

@lpinca since these commits are all related, do you think I should squash them?

Yes, please do it. Thank you.

CI: https://ci.nodejs.org/job/node-test-pull-request/33984/

Landed in c0af8bd.

PR-URL: #35830 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 27, 2020

aduh95 added the brotli Issues and PRs related to the brotli dependency. label Oct 27, 2020

Trott approved these changes Oct 27, 2020

View reviewed changes

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020

lpinca approved these changes Oct 28, 2020

View reviewed changes

Comment thread test/parallel/test-zlib-invalid-arg-value-brotli-compress.js Outdated

Comment thread test/parallel/test-zlib-invalid-arg-value-brotli-compress.js Outdated

zlib: test BrotliCompress throws invalid arg value

a9ce812

RaisinTen force-pushed the test-zlib-invalid-arg-value-brotlicompress branch from 122b8f1 to a9ce812 Compare October 28, 2020 12:31

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020

This comment has been minimized.

Sign in to view

rickyes approved these changes Oct 31, 2020

View reviewed changes

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020

lpinca pushed a commit that referenced this pull request Oct 31, 2020

zlib: test BrotliCompress throws invalid arg value

c0af8bd

PR-URL: #35830 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

lpinca closed this Oct 31, 2020

RaisinTen deleted the test-zlib-invalid-arg-value-brotlicompress branch October 31, 2020 05:49

targos pushed a commit that referenced this pull request Nov 3, 2020

zlib: test BrotliCompress throws invalid arg value

102d7df

PR-URL: #35830 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

targos mentioned this pull request Nov 3, 2020

v15.1.0 release proposal #35948

Merged

BethGriggs pushed a commit that referenced this pull request Dec 8, 2020

zlib: test BrotliCompress throws invalid arg value

0ea3a91

PR-URL: #35830 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

BethGriggs pushed a commit that referenced this pull request Dec 10, 2020

zlib: test BrotliCompress throws invalid arg value

0d80a93

PR-URL: #35830 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

BethGriggs mentioned this pull request Dec 10, 2020

v14.15.2 proposal #36476

Merged

BethGriggs pushed a commit that referenced this pull request Dec 15, 2020

zlib: test BrotliCompress throws invalid arg value

f59e225

PR-URL: #35830 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

137717unity mentioned this pull request May 22, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 137717unity/node#95

Open

snyk-bot mentioned this pull request May 23, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 ron-a20/node#95

Open

wedataintelligence mentioned this pull request May 24, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 wedataintelligence/node#77

Open

baby636 mentioned this pull request May 24, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.6.24 to 3.15.0 baby636/node#92

Open

aliceUnhinged613 mentioned this pull request Nov 25, 2023

[Snyk] Fix for 28 vulnerabilities aliceUnhinged613/node#98

Open

wedataintelligence mentioned this pull request Nov 28, 2023

[Snyk] Fix for 28 vulnerabilities wedataintelligence/node#87

Open

baby636 mentioned this pull request Nov 28, 2023

[Snyk] Fix for 37 vulnerabilities baby636/node#110

Open

ron-a20 mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities ron-a20/node#112

Open

137717unity mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities 137717unity/node#113

Open

wedataintelligence mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities wedataintelligence/node#96

Open

aliceUnhinged613 mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities aliceUnhinged613/node#114

Open

baby636 mentioned this pull request Dec 20, 2023

[Snyk] Fix for 43 vulnerabilities baby636/node#126

Open

137717unity mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 137717unity/node#125

Open

aliceUnhinged613 mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 aliceUnhinged613/node#125

Open

ron-a20 mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 ron-a20/node#123

Open

molllyn1 mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 molllyn1/node#109

Open

kissofire mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.2.13 to 3.15.0 kissofire/node#126

Open

wedataintelligence mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 wedataintelligence/node#108

Open

baby636 mentioned this pull request Apr 15, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.6.24 to 3.15.0 baby636/node#146

Open

zlib: test BrotliCompress throws invalid arg value by RaisinTen · Pull Request #35830 · nodejs/node · GitHub

Uh oh!

Uh oh!

zlib: test BrotliCompress throws invalid arg value - #35830

zlib: test BrotliCompress throws invalid arg value#35830
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:test-zlib-invalid-arg-value-brotlicompress

RaisinTen commented Oct 27, 2020

Uh oh!

nodejs-github-bot commented Oct 27, 2020

Uh oh!

Uh oh!

Uh oh!

RaisinTen commented Oct 28, 2020 •
edited
Loading

Uh oh!

Uh oh!

lpinca commented Oct 28, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Oct 31, 2020

Uh oh!

lpinca commented Oct 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	throw new ERR_INVALID_ARG_TYPE('options.params[key]',
	'number', opts.params[origKey]);
	}

zlib: test BrotliCompress throws invalid arg value by RaisinTen · Pull Request #35830 · nodejs/node · GitHub

Uh oh!

Uh oh!

zlib: test BrotliCompress throws invalid arg value - #35830

zlib: test BrotliCompress throws invalid arg value#35830RaisinTen wants to merge 1 commit intonodejs:masternodejs/node:masterfrom RaisinTen:test-zlib-invalid-arg-value-brotlicompressRaisinTen/node:test-zlib-invalid-arg-value-brotlicompressCopy head branch name to clipboard

Conversation

RaisinTen commented Oct 27, 2020

Checklist

Uh oh!

nodejs-github-bot commented Oct 27, 2020

Uh oh!

Uh oh!

Uh oh!

RaisinTen commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lpinca commented Oct 28, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Oct 31, 2020

Uh oh!

lpinca commented Oct 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zlib: test BrotliCompress throws invalid arg value#35830
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:test-zlib-invalid-arg-value-brotlicompress

RaisinTen commented Oct 28, 2020 •
edited
Loading