FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: use primordials when calling methods of Error global object by aduh95 · Pull Request #35837 · nodejs/node · GitHub

/ node Public

lib: use primordials when calling methods of Error global object - #35837

Closed
aduh95 wants to merge 2 commits into
nodejs:masterfrom
aduh95:error-prototype-optional-chaining
ConversationCommits (2)ChecksFiles changed
Closed

lib: use primordials when calling methods of Error global object#35837
aduh95 wants to merge 2 commits into
nodejs:masterfrom
aduh95:error-prototype-optional-chaining

Conversation

aduh95 commented Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 27, 2020

Trott commented Oct 27, 2020

Copy link
Copy Markdown
Member

Should we add a test that crashes things now but won't crash with this change?

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020

This comment has been minimized.

Sign in to view

devsnek commented Oct 27, 2020

Copy link
Copy Markdown
Member

Shouldn't we use primordials instead?

lib: use primordials when calling methods of Error
b642e52 
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

aduh95 commented Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Shouldn't we use primordials instead?

Actually we can. I don't know why I had the preconceived notion that Error was not accessible from primordials. Thanks for the suggestion, I've implemented it.

Should we add a test that crashes things now but won't crash with this change?

@Trott Is it still needed now that I'm using primordials?

aduh95 force-pushed the error-prototype-optional-chaining branch from 9455338 to b642e52 Compare October 28, 2020 09:42
aduh95 changed the title lib: use optional chaining when calling methods of Error prototype lib: use primordials when calling methods of Error global object Oct 28, 2020
aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed dont-land-on-v10.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 28, 2020
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

This comment has been minimized.

Sign in to view
aduh95 mentioned this pull request Oct 28, 2020
Closed
3 tasks

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33907/

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 28, 2020
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2020

github-actions Bot commented Oct 30, 2020

Copy link
Copy Markdown
Contributor

Landed in 05bb1b3...1da6729

github-actions Bot closed this Oct 30, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2020
lib: use primordials when calling methods of Error
1da6729 
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

PR-URL: #35837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
lib: use primordials when calling methods of Error
b1e531a 
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

PR-URL: #35837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
lib: use primordials when calling methods of Error
8de4b4d 
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

PR-URL: #35837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
lib: use primordials when calling methods of Error
25e8d4b 
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

PR-URL: #35837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
lib: use primordials when calling methods of Error
41d997c 
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

PR-URL: #35837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
aduh95 deleted the error-prototype-optional-chaining branch July 16, 2022 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
+2 more reviewers
Leko Leko approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL