FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build,tools: GitHub Actions: use Node.js Fermium by aduh95 · Pull Request #35840 · nodejs/node · GitHub

/ node Public

build,tools: GitHub Actions: use Node.js Fermium - #35840

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:gh-actions-node-14
Oct 30, 2020
ConversationCommits (1)ChecksFiles changed
Merged

build,tools: GitHub Actions: use Node.js Fermium#35840
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:gh-actions-node-14

Conversation

aduh95 commented Oct 27, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 27, 2020
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33896/

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 28, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2020

github-actions Bot commented Oct 30, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/35840
✔  Done loading data for nodejs/node/pull/35840
----------------------------------- PR info ------------------------------------
Title      build,tools: GitHub Actions: use Node.js Fermium (#35840)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:gh-actions-node-14 -> nodejs:master
Labels     author ready, meta
Commits    1
 - build,tools: GitHub Actions: use Node.js Fermium
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/35840
Reviewed-By: Jiawen Geng 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35840
Reviewed-By: Jiawen Geng 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-10-28T08:38:48Z: https://ci.nodejs.org/job/node-test-pull-request/33896/
- Querying data for job/node-test-pull-request/33896/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Tue, 27 Oct 2020 23:28:32 GMT
   ✔  Approvals: 2
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/35840#pullrequestreview-518266606
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35840#pullrequestreview-518286573
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 35840
From https://github.com/nodejs/node
 * branch                  refs/pull/35840/merge -> FETCH_HEAD
✔  Fetched commits as 1da672994ac2..8aff91fb5ac9
--------------------------------------------------------------------------------
[master b9d11b2430] build,tools: GitHub Actions: use Node.js Fermium
 Author: Antoine du Hamel 
 Date: Wed Oct 28 00:26:46 2020 +0100
 4 files changed, 10 insertions(+), 4 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
build,tools: GitHub Actions: use Node.js Fermium

PR-URL: #35840

Reviewed-By: Jiawen Geng technicalcute@gmail.com

Reviewed-By: Rich Trott rtrott@gmail.com


[master 2b0141ba42] build,tools: GitHub Actions: use Node.js Fermium

Author: Antoine du Hamel duhamelantoine1995@gmail.com

Date: Wed Oct 28 00:26:46 2020 +0100

4 files changed, 10 insertions(+), 4 deletions(-)

✖  2b0141ba429f82862605a8e020c5261e45d60f0b

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✖  0:14     First word after subsystem(s) in title should be lowercase. title-format

✔  0:0      Title is <= 50 columns.                   title-length


ℹ  Please fix the commit message and try again.

Commit Queue action: https://github.com/nodejs/node/actions/runs/337539246

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 30, 2020
build,tools: gitHub Actions: use Node.js Fermium
876d816 
PR-URL: nodejs#35840
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos commented Oct 30, 2020

Copy link
Copy Markdown
Member

Suggestion to fix the commit message:

build,tools: use Node.js Fermium in GitHub Actions

aduh95 force-pushed the gh-actions-node-14 branch from 8aff91f to 876d816 Compare October 30, 2020 11:11

aduh95 commented Oct 30, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 876d816

aduh95 merged commit 876d816 into nodejs:master Oct 30, 2020
aduh95 deleted the gh-actions-node-14 branch October 30, 2020 11:12

aduh95 commented Oct 30, 2020

Copy link
Copy Markdown
Contributor Author

Suggestion to fix the commit message:

build,tools: use Node.js Fermium in GitHub Actions

Oh that would have been better! Sorry I didn't see your comment in time.

targos pushed a commit that referenced this pull request Nov 3, 2020
build,tools: gitHub Actions: use Node.js Fermium
4447ff1 
PR-URL: #35840
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
build,tools: gitHub Actions: use Node.js Fermium
38acf9f 
PR-URL: #35840
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
build,tools: gitHub Actions: use Node.js Fermium
e090fd7 
PR-URL: #35840
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
build,tools: gitHub Actions: use Node.js Fermium
50552fa 
PR-URL: #35840
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
gengjiawen gengjiawen approved these changes
+1 more reviewer
crypt096 crypt096 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL