FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: revise v8.getHeapSnapshot() by Trott · Pull Request #35849 · nodejs/node · GitHub

/ node Public

doc: revise v8.getHeapSnapshot() - #35849

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:v8heapsnapshot
Nov 6, 2020
Merged

doc: revise v8.getHeapSnapshot()#35849
Trott merged 1 commit into
nodejs:masterfrom
Trott:v8heapsnapshot

Conversation

Trott commented Oct 28, 2020
edited
Loading

Copy link
Copy Markdown
Member
  • move entry above v8.getHeapSpaceStatistics() (where it belongs
    alphabetically and is not out of place logically)
  • split lengthy sentence into two sentences
Checklist

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 28, 2020

Trott commented Oct 30, 2020

Copy link
Copy Markdown
Member Author

@nodejs/documentation

a0viedo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: nodejs#35849
Reviewed-By: Michael Dawson <midawson@redhat.com>

Trott commented Nov 6, 2020

Copy link
Copy Markdown
Member Author

Landed in ec400f8

Trott merged commit ec400f8 into nodejs:master Nov 6, 2020
Trott deleted the v8heapsnapshot branch November 6, 2020 13:01
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams mentioned this pull request Nov 9, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL