FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: refactor to use more primordials by aduh95 · Pull Request #35875 · nodejs/node · GitHub

/ node Public

lib: refactor to use more primordials - #35875

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:v8-proc-processor-primordials
Nov 5, 2020
Merged

lib: refactor to use more primordials#35875
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:v8-proc-processor-primordials

Conversation

aduh95 commented Oct 29, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 29, 2020
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020

This comment has been minimized.

This comment has been minimized.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020

This comment has been minimized.

nodejs-github-bot commented Oct 30, 2020
edited by aduh95
Loading

Copy link
Copy Markdown
Collaborator

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 30, 2020
aduh95 mentioned this pull request Nov 1, 2020
2 tasks
aduh95 added the review wanted PRs that need reviews. label Nov 1, 2020
PR-URL: nodejs#35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95 force-pushed the v8-proc-processor-primordials branch from 8d380c1 to c723e4c Compare November 5, 2020 22:16

aduh95 commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

Landed in c723e4c

aduh95 merged commit c723e4c into nodejs:master Nov 5, 2020
aduh95 deleted the v8-proc-processor-primordials branch November 5, 2020 22:16
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Nov 9, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. review wanted PRs that need reviews. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL