FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: update old comment style test_util.cc by RaisinTen · Pull Request #35884 · nodejs/node · GitHub

/ node Public

test: update old comment style test_util.cc - #35884

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:test/update-old-comment-style-test_util.cc
Closed

test: update old comment style test_util.cc#35884
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:test/update-old-comment-style-test_util.cc

Conversation

Copy link
Copy Markdown
Member

I was reading the C++ coding style and thought about updating the old comments.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 30, 2020
gireeshpunathil added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020

Copy link
Copy Markdown
Collaborator

gireeshpunathil added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 6, 2020

Copy link
Copy Markdown
Collaborator

gireeshpunathil added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2020

github-actions Bot commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Landed in ec400f8...be17886

github-actions Bot closed this Nov 6, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 6, 2020
PR-URL: #35884
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RaisinTen deleted the test/update-old-comment-style-test_util.cc branch November 6, 2020 13:55
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
PR-URL: #35884
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Nov 9, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
PR-URL: #35884
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35884
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35884
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL