domain: refactor to use more primordials - #35885
Closed
aduh95 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/domains can you review this please? |
Sorry, something went wrong.
Trott
approved these changes
Nov 6, 2020
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 6, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35885 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FWIW I'm using ReflectApply to replace uses of Function.prototype.apply and Function.prototype.call because it has less overhead (see #35838 (review) for more info).
Checklist