Revert "console: rename argument of time and timeEnd" - #3590
Conversation
Sorry, something went wrong.
Turns out the argument is actually called label in the console spec, while being wrongly named on MDN. A correction to MDN will follow. This reverts commit 8c043c1.
|
LGTM |
Sorry, something went wrong.
|
There is no real console spec (that repo is not what is implemented in browsers), so I'm not sure this buys you anything. If you are really interested you could try doing console.time.toString() in a variety of browsers and seeing what they say... |
Sorry, something went wrong.
|
@domenic do you have a trick to see the actual code instead of function time() { [native code] } ? |
Sorry, something went wrong.
|
Well you can look at the source, for the open source browsers (i.e. not Edge). But parameters will be shown anyway, so your result indicates that that browser doesn't give the parameters any names at all. |
Sorry, something went wrong.
|
LGTM but don't see it as a priority |
Sorry, something went wrong.
|
Updated MDN: |
Sorry, something went wrong.
Turns out the argument is actually called label in the console spec, while being wrongly named on MDN. This reverts commit 8c043c1. MDN has been updated in: https://developer.mozilla.org/en-US/docs/Web/API/Console/timeEnd$compare?locale=en-US&to=947893&from=918571 https://developer.mozilla.org/en-US/docs/Web/API/Console/time$compare?locale=en-US&to=947891&from=896987 PR-URL: #3590 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Turns out the argument is actually called label in the console spec, while being wrongly named on MDN. This reverts commit 8c043c1. MDN has been updated in: https://developer.mozilla.org/en-US/docs/Web/API/Console/timeEnd$compare?locale=en-US&to=947893&from=918571 https://developer.mozilla.org/en-US/docs/Web/API/Console/time$compare?locale=en-US&to=947891&from=896987 PR-URL: #3590 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
No need for this to land on lts as 8c043c1 never landed being part of a semver-major change |
Sorry, something went wrong.
|
I documented the process of coming to this conclusion on twitter if you wish to find out more |
Sorry, something went wrong.
The argument name in the documentation was changed to match MDN in 8c043c1, but as it turns out the argument is actually called label in the console spec. I'll fix this on MDN soon after this commit lands.
cc: @targos @aks-