FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update to cjs-module-lexer@0.5.2 by guybedford · Pull Request #35901 · nodejs/node · GitHub

/ node Public

deps: update to cjs-module-lexer@0.5.2 - #35901

Closed
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:lexer-update
ConversationCommits (1)ChecksFiles changed
Closed

deps: update to cjs-module-lexer@0.5.2#35901
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:lexer-update

Conversation

guybedford commented Oct 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This updates to cjs-module-lexer@0.5.2, with the patches to improve the getter detection over the previous global opt-out of getters to specifically match the exact forms used by the Babel (and RollupJS and other build tool) getter output for reexports in strict conversions, implemented in nodejs/cjs-module-lexer#25 and nodejs/cjs-module-lexer#26.

This fixes the regression in #35893.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

guybedford mentioned this pull request Oct 31, 2020
Closed

guybedford commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

I'd like to request a fast track for this PR.

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34001/

guybedford commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

Ping @nodejs/modules-active-members for review.

aduh95 commented Oct 31, 2020

Copy link
Copy Markdown
Contributor

This fixes the regression in #35893.

I'm still able to reproduce the related issue when applying the patch from this PR… Am I missing something?

guybedford changed the title deps: update to cjs-module-lexer@0.5.1 deps: update to cjs-module-lexer@0.5.2 Oct 31, 2020

guybedford commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

@aduh95 thanks so much for checking this, I've updated the PR to a 0.5.2 supporting named getter functions, it's working now for the example I can confirm.

nodejs-github-bot commented Oct 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34002/

aduh95 commented Oct 31, 2020

Copy link
Copy Markdown
Contributor

Yes, I can confirm the new version solves the issue 🎉

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 31, 2020
guybedford added a commit that referenced this pull request Nov 1, 2020
deps: update to cjs-module-lexer@0.5.2
5735525 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

guybedford commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 5735525.

guybedford closed this Nov 1, 2020
guybedford deleted the lexer-update branch November 1, 2020 01:43
targos pushed a commit that referenced this pull request Nov 3, 2020
deps: update to cjs-module-lexer@0.5.2
1303a1f 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
deps: update to cjs-module-lexer@0.5.2
72b1ef8 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
deps: update to cjs-module-lexer@0.5.2
0a12e9d 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Nov 16, 2020
deps: update to cjs-module-lexer@0.5.2
0356963 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
deps: update to cjs-module-lexer@0.5.2
bdcc77b 
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL