events: support defining event handlers on prototypes - #35931
Closed
benjamingr wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
benjamingr
requested review from
addaleax,
jasnell and
watilde
and removed request for
addaleax and
watilde
November 2, 2020 21:04
Copy link
Copy Markdown
Member
Author
|
I am also not sure about semver-ness. I doubt anyone was relying on the current behaviour but 🤷♂️ |
Sorry, something went wrong.
addaleax
reviewed
Nov 2, 2020
Comment thread
lib/internal/event_target.js
Outdated
addaleax
approved these changes
Nov 2, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
reviewed
Nov 2, 2020
Comment thread
lib/internal/event_target.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Nov 3, 2020
Comment thread
test/parallel/test-eventtarget.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: this change seems unnecessary
Suggested change
| throws | |
| throws, |
Sorry, something went wrong.
benjamingr
force-pushed
the
event-handler-fixes
branch
from
c26621f to
9758914
Compare
November 4, 2020 10:20
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
watilde
approved these changes
Nov 4, 2020
watilde
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice :)
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Nov 4, 2020
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM pending rebase to resolve conflicts
Sorry, something went wrong.
benjamingr
force-pushed
the
event-handler-fixes
branch
from
9758914 to
3bf58ba
Compare
November 4, 2020 14:17
4 tasks
Copy link
Copy Markdown
Member
Author
|
@aduh95 awesome, I didn't know that good to know I'll use it in the future it's helpful :] |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows defining event handlers on prototypes and not just on instances.
Fixes a TODO in the code
CC @addaleax
Checklist