http2: Fix error stream write followed by destroy - #35951
Merged
Trott merged 1 commit intoNov 6, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
crypt096
approved these changes
Nov 4, 2020
mcollina
approved these changes
Nov 4, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
rickyes
approved these changes
Nov 5, 2020
Comment thread
test/parallel/test-http2-destroy-after-write.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| session.on('stream', function(stream) { | |
| session.on('stream', common.mustCall(function(stream) { |
Sorry, something went wrong.
Comment thread
test/parallel/test-http2-destroy-after-write.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| server.on('session', function(session) { | |
| server.on('session', common.mustCall(function(session) { |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Nov 5, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There seems to be a problem on ARM :( |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
14:22:04 + git checkout -f refs/remotes/jenkins_tmp 14:22:04 fatal: Unable to create '/home/iojs/build/workspace/node-test-binary-arm/.git/index.lock': File exists. 14:22:04 14:22:04 Another git process seems to be running in this repository, ... 14:22:07 mkdir: cannot create directory ‘out/junit’: No such file or directory |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Should have been fixed by nodejs/build#2475, I've resumed the last CI run. |
Sorry, something went wrong.
PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Without the fix, the test fails with:
node:internal/http2/core:179 debugStream(stream[kID], stream[kSession][kType], message, ...args); ^ TypeError: Cannot read property 'Symbol(type)' of undefined at debugStreamObj (node:internal/http2/core:179:44) at node:internal/http2/core:2041:7 at processTicksAndRejections (node:internal/process/task_queues:75:11)