test: fix error in test/internet/test-dns.js - #35969
Merged
Trott merged 1 commit intoNov 5, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Fast-track to fix failing test in node-daily-master? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17343/ There's a different DNS test that I expect to still fail but this one should now pass. |
Sorry, something went wrong.
richardlau
approved these changes
Nov 4, 2020
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Subsystem should be test instead of doc but otherwise 👍.
Sorry, something went wrong.
lpinca
approved these changes
Nov 4, 2020
addaleax
approved these changes
Nov 4, 2020
aduh95
approved these changes
Nov 4, 2020
Copy link
Copy Markdown
Member
Author
Fixed. Thanks. |
Sorry, something went wrong.
Refs: nodejs#35466 (comment) PR-URL: nodejs#35969 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
Refs: #35466 (comment) PR-URL: #35969 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: #35466 (comment) PR-URL: #35969 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #35466 (comment)
Checklist