FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: ignore build artifacts for napi addons by richardlau · Pull Request #35970 · nodejs/node · GitHub

/ node Public

benchmark: ignore build artifacts for napi addons - #35970

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:ignore
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: ignore build artifacts for napi addons#35970
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:ignore

Conversation

richardlau commented Nov 4, 2020

Copy link
Copy Markdown
Member

Add .gitignore to ignore the build directory in a similar way
to the other addons under benchmark/napi.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Nov 4, 2020

richardlau commented Nov 4, 2020

Copy link
Copy Markdown
Member Author

Adding watch labels for the release lines that #28237 has landed.

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020

This comment has been minimized.

Sign in to view
benchmark: ignore build artifacts for napi addons
8a22f7d 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34076/

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34082/

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34092/

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34093/

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34096/

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34097/

nodejs-github-bot commented Nov 5, 2020 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34101/ (✅)

richardlau added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 5, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2020

github-actions Bot commented Nov 7, 2020

Copy link
Copy Markdown
Contributor

Landed in 3c9f072...85b42af

github-actions Bot closed this Nov 7, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 7, 2020
benchmark: ignore build artifacts for napi addons
85b42af 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau deleted the ignore branch November 7, 2020 03:00
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
benchmark: ignore build artifacts for napi addons
9d9a044 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Nov 9, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
benchmark: ignore build artifacts for napi addons
f7ee9f2 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
benchmark: ignore build artifacts for napi addons
c6eb0b6 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Nov 16, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
benchmark: ignore build artifacts for napi addons
aa18ac0 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
benchmark: ignore build artifacts for napi addons
930bc5d 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
benchmark: ignore build artifacts for napi addons
d027be0 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL