FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dns: fix trace_events name for resolveCaa() by Trott · Pull Request #35979 · nodejs/node · GitHub

/ node Public

dns: fix trace_events name for resolveCaa() - #35979

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-dns-trace
Nov 9, 2020
ConversationCommits (1)ChecksFiles changed
Merged

dns: fix trace_events name for resolveCaa()#35979
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-dns-trace

Conversation

Trott commented Nov 5, 2020

Copy link
Copy Markdown
Member

A test was added for this in 6f34498 but because it was a test in the
internet directory, it was not run on CI and it was not noticed that
the test was failing. This fixes the error that was causing the test to
fail.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Nov 5, 2020
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

Trott commented Nov 5, 2020

Copy link
Copy Markdown
Member Author

Internet test: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17369/

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34095/

nodejs-github-bot commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34103/

Trott commented Nov 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Internet test: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17369/

Whoops, that was against master and shows the failure. Here's against this PR to show success:

Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17425/ ✅

Trott commented Nov 8, 2020

Copy link
Copy Markdown
Member Author

@nodejs/testing @nodejs/dns This fixes the node-daily-master CI job. One more review/approval would be helpful.

dns: fix trace_events name for resolveCaa()
642174a 
A test was added for this in 6f34498 but because it was a test in the
`internet` directory, it was not run on CI and it was not noticed that
the test was failing. This fixes the error that was causing the test to
fail.

PR-URL: nodejs#35979
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott merged commit 642174a into nodejs:master Nov 9, 2020

Trott commented Nov 9, 2020

Copy link
Copy Markdown
Member Author

Landed in 642174a

Trott deleted the fix-dns-trace branch November 9, 2020 13:58
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
dns: fix trace_events name for resolveCaa()
4b03670 
A test was added for this in 6f34498 but because it was a test in the
`internet` directory, it was not run on CI and it was not noticed that
the test was failing. This fixes the error that was causing the test to
fail.

PR-URL: #35979
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams mentioned this pull request Nov 9, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
dns: fix trace_events name for resolveCaa()
0f126d0 
A test was added for this in 6f34498 but because it was a test in the
`internet` directory, it was not run on CI and it was not noticed that
the test was failing. This fixes the error that was causing the test to
fail.

PR-URL: #35979
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL