tools,doc: enable ecmaVersion 2021 in acorn parser - #35994
Closed
aduh95 wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
benjamingr
approved these changes
Nov 6, 2020
This comment has been minimized.
Trott
approved these changes
Nov 6, 2020
Copy link
Copy Markdown
Member
LGTM but I'm wondering why it's not "latest" as in that PR? (I'm guessing it's because it is either unsupported in the version of acorn we're using here or else unsupported entirely in this particular API.) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Nope, it's just I only checked the first commit listed in GitHub UI instead of checking what actually landed 😅 Upgraded to latest. |
Sorry, something went wrong.
gengjiawen
approved these changes
Nov 6, 2020
This comment has been minimized.
DerekNonGeneric
approved these changes
Nov 6, 2020
Copy link
Copy Markdown
Member
|
Any chance this can be fast-tracked as it's failing other builds and doesn't impact the user facing bits? 👍 for fast tracking |
Sorry, something went wrong.
lpinca
approved these changes
Nov 6, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2020
PR-URL: #35994 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35994 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35994 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35994 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35994 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #35827, but for parsing node source code when generating doc files.
Checklist