If you could change other .finally calls in this file as well, that'd be nice.

Sorry for the force push, I following the commit guidelines now (I hope)

@baruchiro Can you rebase to resolve the conflict please?

git fetch upstream master
git rebase upstream/master -i

About initializing the workspace and running vcbuild test, I found a bug in the vcbuild.bat file related to *Visual Studio 19 Preview`, I have one fix for that (but it not solving the whole process).

Where should I open a bug and/or PR for that?

(PR will be here, of course... But should I open an issue first? Do I need to open the issue in the current repo, even if it not related to node itself, but to the repo itself?)

Where should I open a bug and/or PR for that?

If you have a fix, PR is very welcome. Issue is not necessary if your PR describes the problem and the solution.

CI: https://ci.nodejs.org/job/node-test-pull-request/34203/ ✅

@benjamingr As first-time contributor I allow myself to ask "what now?"

When this PR will be merged?
Do I need to do something?

@baruchiro Your PR is author ready, that means you don't have anything left to do :) You just have to wait for someone landing it for you on master. You can read more about what's the process here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#accepting-modifications

Landed in 36fbbe0...a8b9ede

@aduh95 So it actually taked my commits into master, but not by the Github PR interface?

Interesting technique 😀

@baruchiro yes, the reasons are outlined here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#landing-pull-requests

But anyway, you are now officially a Node.js contributor, congrats 🎉

Hooray!! 🥇

But now I can't write that in my CV, because I don't know how to answer the question "What you did as a Node.js contributor?"... 😉😉

Never mind, I'm sure the next contribution I will understand more. I just need to find the next one.

Feel free to ping me on Facebook for more contribution ideas :)