test: use global.EventTarget instead of internals - #36002
Merged
aduh95 merged 1 commit intoNov 9, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
4 tasks
targos
approved these changes
Nov 7, 2020
This comment has been minimized.
benjamingr
approved these changes
Nov 7, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
`EventTarget` is exposed on the global scope, there is no need to use `--expose-internals` flag in the tests. Refs: nodejs#35496 PR-URL: nodejs#36002 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95
force-pushed
the
test-global-eventtarget
branch
from
06bd33a to
36fbbe0
Compare
November 9, 2020 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventTarget and Event are available from the global scope, there is no need to use the --expose-internals flag in the tests.
Refs: #35496
Checklist