FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

timers: cleanup abort listener on awaitable timers by jasnell · Pull Request #36006 · nodejs/node · GitHub

/ node Public

timers: cleanup abort listener on awaitable timers - #36006

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:cleanup-cancelable-awaitable-timers
ConversationCommits (1)ChecksFiles changed
Closed

timers: cleanup abort listener on awaitable timers#36006
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:cleanup-cancelable-awaitable-timers

Conversation

jasnell commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Alternative to #35992 ... cleanup
abort listeners when timer successfully fires

Co-authored-by: Benjamin Gruenbaum benjamingr@gmail.com
Signed-off-by: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

jasnell added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 6, 2020
jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020

This comment has been minimized.

Sign in to view
aduh95 reviewed Nov 6, 2020
View reviewed changes
Comment thread lib/timers/promises.js Outdated
Comment thread lib/timers/promises.js Outdated
timers: cleanup abort listener on awaitable timers
dd09415 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell force-pushed the cleanup-cancelable-awaitable-timers branch from 5e06324 to dd09415 Compare November 6, 2020 22:24
jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020

nodejs-github-bot commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34147/

benjamingr mentioned this pull request Nov 7, 2020
Closed
4 tasks
mcollina approved these changes Nov 7, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Nov 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34167/

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 7, 2020
benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 9, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020

github-actions Bot commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Landed in 1a6d4dc...aa1eb1f

github-actions Bot closed this Nov 9, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020
timers: cleanup abort listener on awaitable timers
aa1eb1f 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
timers: cleanup abort listener on awaitable timers
77e4f19 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams mentioned this pull request Nov 9, 2020
Merged
targos added a commit that referenced this pull request May 16, 2021
timers: cleanup abort listener on awaitable timers
538ec98 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
timers: cleanup abort listener on awaitable timers
d84b05a 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36006
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
deokjinkim added a commit to deokjinkim/node that referenced this pull request Apr 28, 2023
test: refactor to use getEventListeners in timers
c8e42f7 
Use `getEventListeners` instead of `listenerCount` because nodejs#35991
was landed.

Refs: nodejs#35991
Refs: nodejs#36006
deokjinkim mentioned this pull request Apr 28, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request May 3, 2023
test: refactor to use getEventListeners in timers
b0ca770 
Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request May 3, 2023
test: refactor to use getEventListeners in timers
159cf02 
Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test: refactor to use getEventListeners in timers
f533b36 
Use `getEventListeners` instead of `listenerCount` because #35991
was landed.

Refs: #35991
Refs: #36006
PR-URL: #47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test: refactor to use getEventListeners in timers
dedbeee 
Use `getEventListeners` instead of `listenerCount` because nodejs#35991
was landed.

Refs: nodejs#35991
Refs: nodejs#36006
PR-URL: nodejs#47759
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
mcollina mcollina approved these changes
addaleax addaleax approved these changes
benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL