FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: refactor to use more primordials by aduh95 · Pull Request #36012 · nodejs/node · GitHub

/ node Public

crypto: refactor to use more primordials - #36012

Merged
Trott merged 0 commit into
nodejs:masterfrom
aduh95:crypto-primordials
Nov 10, 2020
Merged

crypto: refactor to use more primordials#36012
Trott merged 0 commit into
nodejs:masterfrom
aduh95:crypto-primordials

Conversation

aduh95 commented Nov 6, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 6, 2020
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 7, 2020
Trott closed this Nov 10, 2020
Trott force-pushed the crypto-primordials branch from 12b9d9f to da53a3c Compare November 10, 2020 04:23

Trott commented Nov 10, 2020

Copy link
Copy Markdown
Member

Landed in da53a3c

Trott merged commit da53a3c into nodejs:master Nov 10, 2020
aduh95 deleted the crypto-primordials branch November 10, 2020 08:38
danielleadams pushed a commit that referenced this pull request Nov 10, 2020
PR-URL: #36012
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL