FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib,tools: enforce access to prototype from primordials by aduh95 · Pull Request #36025 · nodejs/node · GitHub

/ node Public

lib,tools: enforce access to prototype from primordials - #36025

Merged
Trott merged 1 commit into
nodejs:masterfrom
aduh95:prototype-primordials
Nov 14, 2020
ConversationCommits (1)ChecksFiles changed
Merged

lib,tools: enforce access to prototype from primordials#36025
Trott merged 1 commit into
nodejs:masterfrom
aduh95:prototype-primordials

Conversation

aduh95 commented Nov 7, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
aduh95 requested a review from Leko November 7, 2020 16:41
nodejs-github-bot added process Issues and PRs related to the process subsystem. tools Issues and PRs related to the tools directory. labels Nov 7, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020

This comment has been minimized.

Sign in to view
This was referenced Nov 7, 2020
Merged
Closed
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2020
aduh95 force-pushed the prototype-primordials branch from 0c56e81 to 6d364f8 Compare November 9, 2020 09:47
aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 9, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2020

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
aduh95 force-pushed the prototype-primordials branch from 249ca96 to 07bab9c Compare November 10, 2020 09:24
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
Trott requested a review from guybedford November 11, 2020 13:27

nodejs-github-bot commented Nov 11, 2020 •
edited by aduh95
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34336/ ✅

lib,tools: enforce access to prototype from primordials
5c3944f 
PR-URL: nodejs#36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott force-pushed the prototype-primordials branch from 26c722d to 5c3944f Compare November 14, 2020 13:57

Trott commented Nov 14, 2020

Copy link
Copy Markdown
Member

Landed in 5c3944f

Trott merged commit 5c3944f into nodejs:master Nov 14, 2020
aduh95 deleted the prototype-primordials branch November 14, 2020 14:24
codebytere pushed a commit that referenced this pull request Nov 22, 2020
lib,tools: enforce access to prototype from primordials
75707f4 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere mentioned this pull request Nov 22, 2020
Merged
targos pushed a commit that referenced this pull request May 16, 2021
lib,tools: enforce access to prototype from primordials
483c1a1 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
lib,tools: enforce access to prototype from primordials
b3e22e1 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
guybedford Awaiting requested review from guybedford
+1 more reviewer
Leko Leko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. process Issues and PRs related to the process subsystem. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL