tls: use the most recently added matching SecureContext in default SN… - #36072
Merged
Trott merged 1 commit intoJan 15, 2021
Merged
tls: use the most recently added matching SecureContext in default SN…#36072Trott merged 1 commit into
Trott merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
4 tasks
mscdex
reviewed
Nov 10, 2020
Comment thread
test/parallel/test-tls-secure-context-usage-order.js
Outdated
mscdex
reviewed
Nov 10, 2020
Comment thread
test/parallel/test-tls-secure-context-usage-order.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
minor nit: we could be more strict here and assert that these are equal depending on the current step, same for the other conditional below
Sorry, something went wrong.
Trott
reviewed
Nov 12, 2020
Comment thread
doc/api/tls.md
Outdated
Trott
approved these changes
Nov 12, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Did a clear rebase, because the previous one failed. @Trott you might want to request another CI. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Jan 7, 2021
PR-URL: nodejs#36072 Fixes: nodejs#34110 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, ruined the previous PR (#34638) with a merge.
Fixes: #34110
Checklist