doc: fix invalid link in worker_threads.md - #36109
Merged
Trott merged 1 commit intoNov 15, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
approved these changes
Nov 13, 2020
gireeshpunathil
approved these changes
Nov 13, 2020
richardlau
approved these changes
Nov 13, 2020
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is it possible to catch this with the link checker?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There may be edge cases, but I believe for any link we'd care about, more than one # character would be an error. So we should be able to flag it. For that matter, running this URL through new URL() would throw an error, so maybe that's a simple check we could add. |
Sorry, something went wrong.
lpinca
approved these changes
Nov 13, 2020
ZYSzys
approved these changes
Nov 13, 2020
watilde
approved these changes
Nov 14, 2020
Inadvertent double hash in link makes it invalid and no longer pointing to the documentation section it intends to point to. PR-URL: nodejs#36109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Inadvertent double hash in link makes it invalid and no longer pointing to the documentation section it intends to point to. PR-URL: #36109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Inadvertent double hash in link makes it invalid and no longer pointing to the documentation section it intends to point to. PR-URL: #36109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inadvertent double hash in link makes it invalid and no longer pointing
to the document it intends to point to.
Checklist