lib: set abort-controller toStringTag - #36115
Closed
benjamingr wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
Nov 14, 2020
aduh95
approved these changes
Nov 14, 2020
Comment thread
lib/internal/abort_controller.js
Outdated
addaleax
approved these changes
Nov 15, 2020
Trott
force-pushed
the
abort-string-tag
branch
from
fd62f71 to
9f80658
Compare
November 16, 2020 14:26
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The CI failure from the rebase looks like a real failure, I'll fix this. |
Sorry, something went wrong.
benjamingr
force-pushed
the
abort-string-tag
branch
from
9f80658 to
e4326ee
Compare
November 19, 2020 09:19
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36115 ✔ Done loading data for nodejs/node/pull/36115 ----------------------------------- PR info ------------------------------------ Title lib: set abort-controller toStringTag (#36115) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch benjamingr:abort-string-tag -> nodejs:master Labels author ready, eventtarget Commits 1 - lib: set abort-controller toStringTag Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/36115 Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36115 Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - lib: set abort-controller toStringTag ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-19T11:25:22Z: https://ci.nodejs.org/job/node-test-pull-request/34463/ - Querying data for job/node-test-pull-request/34463/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sat, 14 Nov 2020 11:48:37 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36115#pullrequestreview-530580303 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36115#pullrequestreview-530582218 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36115#pullrequestreview-530807605 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/372460457 |
Sorry, something went wrong.
jasnell
approved these changes
Nov 19, 2020
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 19, 2020
PR-URL: #36115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
PR-URL: #36115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#36115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty small fix for AbortController/AbortSignal defining Symbol.toStringTag like we're supposed to. This already works on EventTarget, isn't a big deal and I think was probably just missed before :]
I am... not sure what to label PRs that touch only AbortController 🤷
Checklist