src: remove empty name check in node_env_var.cc - #36133
Closed
RaisinTen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
RaisinTen
marked this pull request as ready for review
November 16, 2020 13:51
Copy link
Copy Markdown
Member
Author
|
/CC @addaleax |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
reviewed
Dec 13, 2020
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM once the still-relevant part of the comment is back :)
Sorry, something went wrong.
Comment thread
src/node_env_var.cc
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I’m not sure why this line is being removed, though?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Whoops, I'll add that back in. Thanks for reviewing. :)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
done
Sorry, something went wrong.
The empty name check has been removed since this has landed: libuv/libuv#2473
RaisinTen
force-pushed
the
update/empty-name-check-node_env_var.cc
branch
from
1206c69 to
76ae744
Compare
December 13, 2020 14:37
addaleax
approved these changes
Dec 13, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Dec 15, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36133 ✔ Done loading data for nodejs/node/pull/36133 ----------------------------------- PR info ------------------------------------ Title src: remove empty name check in node_env_var.cc (#36133) Author Darshan Sen (@RaisinTen) Branch RaisinTen:update/empty-name-check-node_env_var.cc -> nodejs:master Labels C++, author ready Commits 1 - src: remove empty name check in node_env_var.cc Committers 1 - raisinten PR-URL: https://github.com/nodejs/node/pull/36133 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36133 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Last Full PR CI on 2020-12-13T14:47:03Z: https://ci.nodejs.org/job/node-test-pull-request/34927/ - Querying data for job/node-test-pull-request/34927/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 16 Nov 2020 12:54:51 GMT ✔ Approvals: 2 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36133#pullrequestreview-550926817 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36133#pullrequestreview-552392117 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/423272881 |
Sorry, something went wrong.
jasnell
approved these changes
Dec 15, 2020
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
The empty name check has been removed since this has landed: libuv/libuv#2473 PR-URL: #36133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
The empty name check has been removed since this has landed: libuv/libuv#2473 PR-URL: #36133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The empty name check has been removed since this has landed: libuv/libuv#2473 PR-URL: #36133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The empty name check has been removed since this has landed:
libuv/libuv#2473
Checklist